Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/840b78cb_64c8b5f9 PS7, Line 52: PULL_UP There is an external pull-up in the schematics. So I dont think an internal pull-up is required. -- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 7 Gerrit-Owner: Jon Murphy <jpmurphy@google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy@google.com> Gerrit-Attention: Tim Van Patten <timvp@google.com> Gerrit-Attention: Mark Hasemeyer <markhas@google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment