5 comments:
File src/soc/mediatek/mt8183/rtc.c:
Patch Set #6, Line 192: directly sent to SoC */
Looks like you're not actually doing that in the 8183 version, so the comment doesn't belong here?
Patch Set #6, Line 198: void rtc_bbpu_power_down(void)
This shuts the system down, right? If so, please call it poweroff() (from <halt.h>), and call halt() at the end to make sure execution cannot continue.
Patch Set #6, Line 237: mdelay(5);
6ms is sort of long... is there any way we could shorten this wait?
Patch Set #6, Line 251: pwrap_write_field(0x790, 0xF, 0xF, 0);
Please give all registers used here named constants.
Patch Set #6, Line 254: switch (rtc_check_state()) {
Everything below this line is identical to mt8173. Please factor it out (e.g. rtc_boot_common() or something like that).
To view, visit change 31046. To unsubscribe, or for help writing mail filters, visit settings.