Attention is currently required from: Hung-Te Lin, Rex-BC Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56764 )
Change subject: soc/mediatek/mt8195: Add devapc basic drivers ......................................................................
Patch Set 2:
(27 comments)
File src/soc/mediatek/mt8195/devapc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/196b6ffa_35a81396 PS2, Line 44: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/03fc7d03_5728999a PS2, Line 51: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/d1db8660_d1cde8d4 PS2, Line 63: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/deab8869_92926d02 PS2, Line 67: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/5dc62d58_9370e84b PS2, Line 69: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/76174734_6b9b8c4a PS2, Line 88: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/05f3d71a_2ba2b199 PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/2ed01b75_312d8b48 PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15), please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/99562820_aff62bda PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/3f9e5722_f20469bd PS2, Line 1439: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/00aca720_7ddfd33c PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/25d33ae8_7c07db8b PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/f3b0f23c_12bfaf50 PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/413a6aa6_31204684 PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/9ad3d461_31274a37 PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/0fe6383d_5eaee648 PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/425cb8d3_c96db708 PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/28ac38bb_bf1fb2fd PS2, Line 1508: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/b67657f8_790e3d14 PS2, Line 1517: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
File src/soc/mediatek/mt8195/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/0b0736b3_6b09f5a3 PS2, Line 72: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/012e6036_49c42957 PS2, Line 77: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/a28231be_31618d15 PS2, Line 85: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/e0922488_393af304 PS2, Line 99: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/42d2a1d9_0e0b8726 PS2, Line 100: #define FORBIDDEN7 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/4ccd1e1d_c1533f8d PS2, Line 102: #define FORBIDDEN12 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/a10a83b3_98b1b3c1 PS2, Line 105: #define FORBIDDEN13 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125575): https://review.coreboot.org/c/coreboot/+/56764/comment/6dc86d0e_d9d12c18 PS2, Line 108: #define FORBIDDEN15 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses