1 Nov
2021
1 Nov
'21
11:59 p.m.
Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58351 )
Change subject: soc/intel/common: add generic gpio lock mechanism ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/58351/comment/2fc7874d_53c30152 PS1, Line 348: gpio_lock_pad
I implemented Karthik's suggestion in the latest patchset, let me know if this is what you had in mi […]
I think you may also need `HAVE_DEBUG_GPIO` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58351
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42979fb89567d8bcd9392da4fb8c4113ef427b14
Gerrit-Change-Number: 58351
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 01 Nov 2021 22:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment