5 comments:
File src/southbridge/intel/i82801gx/chip.h:
Patch Set #8, Line 20: #include <southbridge/intel/i82801gx/i82801gx.h>
Would it be better to define the enum here?
File src/southbridge/intel/i82801gx/ide.c:
Patch Set #8, Line 22: #include "chip.h"
...
File src/southbridge/intel/i82801gx/sata.c:
Patch Set #8, Line 53: static int ahci_supported = -1;
Some idea: Update `config->sata_mode` instead. That would save some
lines, only have to be called once and probably make the `switch` logic
in sata_init() easier.
Patch Set #8, Line 58: pcidev_path_on_root
or:
pcidev_on_root(31, 0)
Patch Set #8, Line 160: ahci_bar[3] = config->sata_ports_implemented;
break here?
To view, visit change 30822. To unsubscribe, or for help writing mail filters, visit settings.