Patch set 4:Code-Review -1
2 comments:
File src/mainboard/google/zork/variants/vilboz/variant.c:
Patch Set #4, Line 49: sku_id
Please do not use SKU IDs for feature differentiation. If this is required a new FW_CONFIG bit should be added.
Patch Set #4, Line 53: MISC_CLK_CNTL1
This register should not be touched directly by the mainboard. Instead there should be a chip config added to `struct soc_amd_picasso_config`: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/amd/picasso/chip.h?id=refs/heads/master#n60
and mainboard should just set/clear that config. Rest of the work should be done as part of SoC code.
To view, visit change 48556. To unsubscribe, or for help writing mail filters, visit settings.