Attention is currently required from: Furquan Shaikh, EricR Lai.
5 comments:
File src/mainboard/intel/adlrvp/devicetree.cb:
Patch Set #34, Line 60: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_CLK_SRC_ALWAYS_ON,
What's the purpose of ClkReq if using a free-running ClkSrc?
File src/soc/intel/alderlake/fsp_params.c:
Patch Set #34, Line 264: config->pch_pcie_rp[i]
To save some redundancy, I would use a pointer as follows:
for (i = 0; i < CONFIG_MAX_ROOT_PORTS; i++) {
const struct pcie_rp_config *const rp_cfg = config->pch_pcie_rp[i];
params->PcieRpL1Substates[i] = get_l1_substate_control(rp_cfg->PcieRpL1Substates);
params->PcieRpLtrEnable[i] = !!(rp_cfg->flags & PCIE_RP_LTR);
params->PcieRpAdvancedErrorReporting[i] = !!(rp_cfg->flags & PCIE_RP_AER);
params->PcieRpHotPlug[i] = !!(rp_cfg->flags & PCIE_RP_HOTPLUG);
params->PcieRpClkReqDetect[i] = !!(rp_cfg->flags & PCIE_RP_CLK_REQ_DETECT);
}
File src/soc/intel/alderlake/romstage/fsp_params.c:
nit: pass pointers instead? It should be more efficient than passing by copy
I'd use a bitwise OR here, but it's not a big deal
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
This is what the current FSP binaries use, but it could change in the future.
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.