Patrick Georgi submitted this change.

View Change

soc/intel/skl: Drop `acpi_mainboard_gnvs`

Literally nobody else uses it and it does nothing.

Change-Id: I7e6466137b5069a7f785972205bd43f3cb25d378
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41112
Reviewed-by: Michael Niewöhner
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/intel/skylake/acpi.c
M src/soc/intel/skylake/include/soc/acpi.h
2 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index 789af1d..20b60e9 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -654,7 +654,6 @@
 
 	if (gnvs) {
 		acpi_create_gnvs(gnvs);
-		acpi_mainboard_gnvs(gnvs);
 		/* And tell SMI about it */
 		smm_setup_structures(gnvs, NULL, NULL);
 
@@ -707,10 +706,6 @@
 	return GPE0_REG_MAX;
 }
 
-__weak void acpi_mainboard_gnvs(global_nvs_t *gnvs)
-{
-}
-
 const char *soc_acpi_name(const struct device *dev)
 {
 	if (dev->path.type == DEVICE_PATH_DOMAIN)
diff --git a/src/soc/intel/skylake/include/soc/acpi.h b/src/soc/intel/skylake/include/soc/acpi.h
index 9b03697..02352f3 100644
--- a/src/soc/intel/skylake/include/soc/acpi.h
+++ b/src/soc/intel/skylake/include/soc/acpi.h
@@ -15,7 +15,6 @@
 
 void acpi_fill_in_fadt(acpi_fadt_t *fadt);
 unsigned long acpi_madt_irq_overrides(unsigned long current);
-void acpi_mainboard_gnvs(global_nvs_t *gnvs);
 void southbridge_inject_dsdt(const struct device *device);
 unsigned long southbridge_write_acpi_tables(const struct device *device,
 	unsigned long current, struct acpi_rsdp *rsdp);

To view, visit change 41112. To unsubscribe, or for help writing mail filters, visit settings.