Sounds like a good protection mechanism. Any reason this is only needed on i945-nehalem?

On Intel: Sandybridge (the next newer one we supported back then) does that check itself in "hardware" (with the assumption that following chipsets will do as well) while for pre-i945 we didn't have SMM.

AMD/Via: Stuff is sufficiently different that they don't fail the same way.

non-x86: no SMM \o/

View Change

To view, visit change 36977. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73527a7feb6151d765295d6449262a2852b30177
Gerrit-Change-Number: 36977
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 27 Nov 2019 14:36:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment