3 comments:
File src/soc/intel/common/acpi/gpio_op.asl:
/*
* Set Pad mode
* Arg0 - GPIO Number
* Arg1 - Pad mode
* 0 = GPIO control pad
* 1 = Native Function 1
* 2 = Native Function 2
* 3 = Native Function 3
*/
Method (GPMO, 2, Serialized)
{
OperationRegion (PREG, SystemMemory, GADD (Arg0), 4)
Field (PREG, AnyAcc, NoLock, Preserve)
{
VAL0, 32
}
Store (VAL0, Local0)
And (Not (GPIOPADMODE_MASK), Local0, Local0)
And (ShiftLeft (Arg1, GPIOPADMODE_SHIFT, Arg1), GPIOPADMODE_MASK, Arg1)
Or (Local0, Arg1, VAL0)
}
/*
* Enable/Disable Tx buffer
* Arg0 - GPIO Number
* Arg1 - TxBuffer state
* 0 = Disable Tx Buffer
* 1 = Enable Tx Buffer
*/
Method (GTXE, 2, Serialized)
{
OperationRegion (PREG, SystemMemory, GADD (Arg0), 4)
Field (PREG, AnyAcc, NoLock, Preserve)
{
VAL0, 32
}
If (LEqual (Arg1, 1)) {
And (Not (GPIOTXBUFDIS_MASK), VAL0, VAL0)
} ElseIf (LEqual (Arg1, 0)){
Or (GPIOTXBUFDIS_MASK, VAL0, VAL0)
}
}
/*
* Enable/Disable Rx buffer
* Arg0 - GPIO Number
* Arg1 - RxBuffer state
* 0 = Disable Rx Buffer
* 1 = Enable Rx Buffer
*/
Method (GRXE, 2, Serialized)
{
OperationRegion (PREG, SystemMemory, GADD (Arg0), 4)
Field (PREG, AnyAcc, NoLock, Preserve)
{
VAL0, 32
}
If (LEqual (Arg1, 1)) {
And (Not (GPIORXBUFDIS_MASK), VAL0, VAL0)
} ElseIf (LEqual (Arg1, 0)){
Or (GPIORXBUFDIS_MASK, VAL0, VAL0)
}
}
Looks like these got added when moving code into gpio_op.asl. Are these used anywhere?
File src/soc/intel/tigerlake/acpi/gpio.asl:
Patch Set #12, Line 122: rg0 >= GPP_B0 && Arg0 <= GPP_A24)
This was intentionally written in ACPI ASL2.0. Why does the CL move it back to old style?
Patch Set #12, Line 21: Device (GPIO)
Why was this device changed? This is going to break compatibility with Linux kernel driver for handling the GPIO community blocks on TGL.
To view, visit change 39111. To unsubscribe, or for help writing mail filters, visit settings.