Nico Huber submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Angel Pons: Looks good to me, approved

mb/lenovo/t431s/devicetree: Use subsystemid inheritance

Change-Id: I247129317799d342b28f2c0ed68949ecbe7d9c75
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37301
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
1 file changed, 12 insertions(+), 32 deletions(-)

diff --git a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
index e69f727..e3388de 100644
--- a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
+++ b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
@@ -13,47 +13,31 @@
 	register "gpu_cpu_backlight" = "0x03d2"
 
 	device domain 0 on
-		device pci 00.0 on
-			subsystemid 0x17aa 0x2208
-		end # host bridge
+		subsystemid 0x17aa 0x2208 inherit
+
+		device pci 00.0 on end # host bridge
 		device pci 01.0 off end # PCIe Bridge for discrete graphics
-		device pci 02.0 on
-			subsystemid 0x17aa 0x2208
-		end # Integrated Graphics Controller
+		device pci 02.0 on end # Integrated Graphics Controller
 		chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
 			# Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock)
 			register "sata_port_map" = "0x13"
 			# T431s has no Express Card slot.
 			register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
-			device pci 14.0 on
-				subsystemid 0x17aa 0x2208
-			end # USB 3.0 Controller
-			device pci 1a.0 on
-				subsystemid 0x17aa 0x2208
-			end # USB Enhanced Host Controller #2
-			device pci 1b.0 on
-				subsystemid 0x17aa 0x2208
-			end # High Definition Audio Controller
+			device pci 14.0 on end # USB 3.0 Controller
+			device pci 1a.0 on end # USB Enhanced Host Controller #2
+			device pci 1b.0 on end # High Definition Audio Controller
 			device pci 1c.0 on # PCIe Port #1
-				subsystemid 0x17aa 0x2208
 				chip drivers/ricoh/rce822 # Ricoh cardreader
 					register "disable_mask" = "0x87"
 					register "sdwppol" = "0"
-					device pci 00.0 on # Ricoh SD card reader
-						subsystemid 0x17aa 0x2208
-					end
+					device pci 00.0 on end # Ricoh SD card reader
 				end
 			end
-			device pci 1c.1 on
-				subsystemid 0x17aa 0x2208
-			end # PCIe Port #2 Integrated Wireless LAN
+			device pci 1c.1 on end # PCIe Port #2 Integrated Wireless LAN
 			device pci 1c.2 off end # PCIe Port #3
-			device pci 1d.0 on
-				subsystemid 0x17aa 0x2208
-			end # USB Enhanced Host Controller #1
+			device pci 1d.0 on end # USB Enhanced Host Controller #1
 			device pci 1e.0 off end # PCI bridge
 			device pci 1f.0 on
-				subsystemid 0x17aa 0x2208
 				chip ec/lenovo/h8
 					register "config0" = "0xa6"
 					register "config1" = "0x09"
@@ -63,12 +47,8 @@
 					register "has_bdc_detection" = "0"
 				end
 			end # LPC Controller
-			device pci 1f.2 on
-				subsystemid 0x17aa 0x2208
-			end # 6 port SATA AHCI Controller
-			device pci 1f.3 on
-				subsystemid 0x17aa 0x2208
-			end # SMBus Controller
+			device pci 1f.2 on end # 6 port SATA AHCI Controller
+			device pci 1f.3 on end # SMBus Controller
 			device pci 1f.6 off end # Thermal
 		end
 	end

To view, visit change 37301. To unsubscribe, or for help writing mail filters, visit settings.