Martin L Roth submitted this change.

View Change

Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved cong yang: Looks good to me, but someone else must approve build bot (Jenkins): Verified
drivers/mipi: Update init code for BOE_NV110WUM_L60

1. Correct bank1 to bank0
2. Adjust CLK duty
3. Fix abnormal power off setting
4. Change VDDE power off frame from VGL to VGH

Fixes: 0d50536("drivers/mipi: Add support for BOE_NV110WUM_L60 panel")

BUG=b:319398058
TEST=boot Ciri with BOE_NV110WUM_L60 and see firmware screen

Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a
Signed-off-by: Ruihai Zhou <zhouruihai@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79897
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: cong yang <yangcong5@huaqin.corp-partner.google.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
---
M src/drivers/mipi/panel-BOE_NV110WUM_L60.c
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/drivers/mipi/panel-BOE_NV110WUM_L60.c b/src/drivers/mipi/panel-BOE_NV110WUM_L60.c
index 79bae69..d30a1cf 100644
--- a/src/drivers/mipi/panel-BOE_NV110WUM_L60.c
+++ b/src/drivers/mipi/panel-BOE_NV110WUM_L60.c
@@ -26,8 +26,8 @@
0x88, 0xFA, 0xFF, 0xFF, 0x8F, 0xFF, 0x08, 0x9A, 0x33),
PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x12, 0x71, 0x3C,
0xA3, 0x11, 0x00, 0x00, 0x00, 0x88, 0xF5, 0x22, 0x8F),
- PANEL_DCS(0xB4, 0x49, 0x49, 0x32, 0x32, 0x14, 0x32, 0x84, 0x7E,
- 0x84, 0x7E, 0x01, 0x9C),
+ PANEL_DCS(0xB4, 0x49, 0x49, 0x32, 0x32, 0x14, 0x32, 0x84, 0x6E,
+ 0x84, 0x6E, 0x01, 0x9C),
PANEL_DCS(0xE9, 0xCD),
PANEL_DCS(0xBA, 0x84),
PANEL_DCS(0xE9, 0x3F),
@@ -75,7 +75,7 @@
0x05, 0x0E, 0x04, 0x94, 0x18, 0x00, 0x10, 0xF0, 0x03, 0x0C,
0x20, 0x00, 0x06, 0x0B, 0x0B, 0x33, 0x0E),
PANEL_DCS(0xBD, 0x01),
- PANEL_DCS(0xD8, 0xFF, 0xAF, 0xFF, 0xFF, 0xFA, 0xA0, 0xFF, 0xAF,
+ PANEL_DCS(0xD8, 0xFF, 0xFF, 0xFF, 0xFF, 0xFA, 0xA0, 0xFF, 0xFF,
0xFF, 0xFF, 0xFA, 0xA0),
PANEL_DCS(0xB1, 0x01, 0xBF, 0x11),
PANEL_DCS(0xCB, 0x86),
@@ -91,7 +91,7 @@
0xA0, 0x00, 0x00),
PANEL_DCS(0xBD, 0x02),
PANEL_DCS(0xB4, 0x02, 0x00, 0xBB, 0x11),
- PANEL_DCS(0xD8, 0xAF, 0xFF, 0xFF, 0xFF, 0xFA, 0xA0, 0xAF, 0xFF,
+ PANEL_DCS(0xD8, 0xFF, 0xAF, 0xFF, 0xFF, 0xFA, 0xA0, 0xFF, 0xAF,
0xFF, 0xFF, 0xFA, 0xA0),
PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00,
0x00, 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20,
@@ -105,7 +105,7 @@
PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8),
PANEL_DCS(0xE9, 0x3F),
PANEL_DCS(0xE1, 0x00),
- PANEL_DCS(0xBD, 0x01),
+ PANEL_DCS(0xBD, 0x00),
PANEL_DCS(0xE9, 0xC4),
PANEL_DCS(0xBA, 0x96),
PANEL_DCS(0xE9, 0x3F),

To view, visit change 79897. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a
Gerrit-Change-Number: 79897
Gerrit-PatchSet: 5
Gerrit-Owner: Ruihai Zhou <zhouruihai@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Yidi Lin <yidilin@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5@huaqin.corp-partner.google.com>
Gerrit-MessageType: merged