Attention is currently required from: Nico Huber, Martin Roth, Furquan Shaikh, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57370 )
Change subject: SMBIOS/SCONFIG: Allow devtree-defined Type 41 entries
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57370/comment/ae8bb045_a2869cf1
PS4, Line 35: Although the preprocessor usage isn't particularly elegant, adjusting
: the devicetree syntax and/or grammar depending on a Kconfig option is
: probably even worse.
A linked list of properties, similar to the linked list of PCIe capabilities? Sounds good.
Agreed they are necessary with things as they stand right now, it's just not a great solution. A linked-list is a neat idea, would love to see what you have up your sleeves 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecca9ada6ee1000674cb5dd7afd5c309d8e1a64b
Gerrit-Change-Number: 57370
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 19:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment