Patch Set 1:

Patch Set 1:

Is this a bug in AvalonXhciEnvService? Could you explain a little bit this "off-by-one" error? I am willing to fix it if possible.

In MullinsPI, GetRomSigPtr() while() loop returns one step early? I must have hit the error to find it out...

Ahh, right... I have missed it. It should be MswAddr <= 0xFFF8. Maybe at some point I will locate it in binary and patch few bits...

View Change

To view, visit change 31074. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic78520f4248f0943769e66a8825911c0ddcc368c
Gerrit-Change-Number: 31074
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 13:47:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment