Attention is currently required from: Tarun Tuli, Eran Mitrani.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/common: provide a list of D-states to enter LPM ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70166/comment/a1df7c9d_c1e9cf54 PS3, Line 7: soc/intel/common and alderlake
Patchset:
PS3: Thanks for moving it to common code.
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/c0e604a1_1801f7ab PS3, Line 233: void soc_lpi_get_constraints(void *unused) : { : acpi_generate_lpi_constraint_table(); : } Can't we remove this method itself?
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/3b6fe2b0_7e5b99b1 PS3, Line 443: return NULL; set size to 0 as we are returning NULL.
https://review.coreboot.org/c/coreboot/+/70166/comment/27d4cf02_a6556caa PS3, Line 486: Need to handle a case when `num_entries` is 0 here.