Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson.
2 comments:
File src/soc/amd/cezanne/Kconfig:
Patch Set #36, Line 126: default 4
if i remember correctly, Kconfig picks the first visible default, so this will basically hard-code AMD_FWM_POSITION_INDEX to 4 unless the board explicitly specifies another AMD_FWM_POSITION_INDEX default, since the mainboard Kconfig is processed before the soc's Kconfig
File src/soc/amd/cezanne/Makefile.inc:
Patch Set #29, Line 46: CONFIG_AMD_FWM_POSITION_INDEX
https://review.coreboot.org/c/coreboot/+/49816 […]
i'd say that CONFIG_AMD_FWM_POSITION_INDEX being empty should be a build error, since that means that the board didn't select a valid flash size which will likely cause some other issues as well; for example CONFIG_ROM_SIZE is also a parameter to amdfwtool.
To view, visit change 48528. To unsubscribe, or for help writing mail filters, visit settings.