[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/basecode: Add bootblock common code

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, Meera Ravindranath, Michael Niewöhner, Usha P, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50955 )

Change subject: soc/intel/common/basecode: Add bootblock common code
......................................................................

Patch Set 3:

(4 comments)

File src/soc/intel/common/basecode/Kconfig:

https://review.coreboot.org/c/coreboot/+/50955/comment/7ae0d048_b6675925 
PS2, Line 6: if SOC_INTEL_COMMON_BASECODE
> Why? Is there an actual dependency on something only […]

Not sure why. I've removed the guard and made SOC_INTEL_COMMON_BASECODE_BOOTBLOCK select SOC_INTEL_COMMON_BASECODE

File src/soc/intel/common/basecode/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/50955/comment/2b35022f_6f425f88 
PS2, Line 27: void bootblock_soc_init(void)
> Moving the entry point to common code makes it harder to pass chip- […]

I agree with the reasoning. However, I would need to reorder some code, which could break stuff I can't easily test...

File src/soc/intel/common/basecode/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/50955/comment/3e7ff881_fa1ecff3 
PS3, Line 16: /* FIXME: Drop function pointer usage */
This is cursed, I know

File src/soc/intel/skylake/bootblock/report_platform.c:

https://review.coreboot.org/c/coreboot/+/50955/comment/dd628b35_0168cd5a 
PS2, Line 5: #include <intelblocks/mp_init.h>
> odd

CPUID macros are in this header.