Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71706 )
Change subject: mb/google/brya/var/omnigul: Update GPIO settings ......................................................................
Patch Set 10: Code-Review+1
(7 comments)
File src/mainboard/google/brya/variants/omnigul/gpio.c:
https://review.coreboot.org/c/coreboot/+/71706/comment/31355f52_354bb9fd PS9, Line 72: PAD_NC(GPP_B23, NONE), Baseboard is already PAD_NC. Do you need to override it?
https://review.coreboot.org/c/coreboot/+/71706/comment/102a3656_9d80f2dc PS9, Line 148: /* E21 : DDP2_CTRLDATA ==> USB_C1_LSX_SOC_RX_STRAP */ : /* E22 : DDPA_CTRLCLK ==> USB_C0_AUX_DC_STRAP_P */ : PAD_CFG_GPO(GPP_E22, 1, DEEP), : /* E23 : DDPA_CTRLDATA ==> USB_C0_AUX_DC_N */ : PAD_CFG_GPO(GPP_E23, 1, DEEP), Could you check GPP_E22 and GPP_E23 the same with baseboard or not?
https://review.coreboot.org/c/coreboot/+/71706/comment/30bcab0b_859fdb6b PS9, Line 194: /* H6 : I2C1_SDA ==> PCH_I2C_TPM_SDA */ : PAD_CFG_NF_LOCK(GPP_H6, NONE, NF1, LOCK_CONFIG), : /* H7 : I2C1_SCL ==> PCH_I2C_TPM_SCL */ : PAD_CFG_NF_LOCK(GPP_H7, NONE, NF1, LOCK_CONFIG), Could you check GPP_H6 and GPP_H7 the same with baseboard or not?
https://review.coreboot.org/c/coreboot/+/71706/comment/c9c7f6e8_7022489a PS9, Line 231: PAD_CFG_NF_LOCK(GPP_R7, NONE, NF3, LOCK_CONFIG), Could you check GPP_R7 setting?
https://review.coreboot.org/c/coreboot/+/71706/comment/7757fbdc_7cc51d31 PS9, Line 233: /* S0 : SNDW0_CLK ==> I2S_SPKR_SCLK_R */ : PAD_CFG_NF_LOCK(GPP_S0, NONE, NF4, LOCK_CONFIG), : /* S1 : SNDW0_DATA ==> I2S_SPKR_SFRM_R */ : PAD_CFG_NF_LOCK(GPP_S1, NONE, NF4, LOCK_CONFIG), Could you check GPP_S0 and GPP_S1 settings?
https://review.coreboot.org/c/coreboot/+/71706/comment/ee618b44_aacd3a86 PS9, Line 240: PAD_NC(GPP_S3, NONE), Could you check GPP_S3 setting?
https://review.coreboot.org/c/coreboot/+/71706/comment/ed43f13d_c6646591 PS9, Line 250: /* GPD2 : LAN_WAKE# ==> EC_PCH_WAKE_ODL */ : PAD_CFG_GPO(GPD2, 1, DEEP), I think it is the same with baseboard. Could you help to check it?