Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Eric Lai: Looks good to me, approved
mb/google/brox: Create lotso variant

Create the lotso variant of the brox reference board by copying
the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.5.0).

BUG=b:333494257
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brox -x -a
make sure the build includes GOOGLE_LOTSO

Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Signed-off-by: Kun Liu <liukun11@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81817
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
---
M src/mainboard/google/brox/Kconfig
M src/mainboard/google/brox/Kconfig.name
A src/mainboard/google/brox/variants/lotso/include/variant/ec.h
A src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
A src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
A src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
A src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
A src/mainboard/google/brox/variants/lotso/overridetree.cb
8 files changed, 47 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig
index 9bc71ca..0ec5220 100644
--- a/src/mainboard/google/brox/Kconfig
+++ b/src/mainboard/google/brox/Kconfig
@@ -64,6 +64,9 @@
select CHROMEOS_WIFI_SAR if CHROMEOS
select SOC_INTEL_STORE_ISH_FW_VERSION

+config BOARD_GOOGLE_LOTSO
+ select BOARD_GOOGLE_BASEBOARD_BROX
+
config BOARD_GOOGLE_GREENBAYUPOC
select BOARD_GOOGLE_BASEBOARD_BROX

@@ -117,10 +120,12 @@
config MAINBOARD_PART_NUMBER
default "Brox_Ec_Ish" if BOARD_GOOGLE_BROX_EC_ISH
default "Brox" if BOARD_GOOGLE_BROX
+ default "Lotso" if BOARD_GOOGLE_LOTSO
default "Greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC

config VARIANT_DIR
default "brox" if BOARD_GOOGLE_BROX || BOARD_GOOGLE_BROX_EC_ISH
+ default "lotso" if BOARD_GOOGLE_LOTSO
default "greenbayupoc" if BOARD_GOOGLE_GREENBAYUPOC

config VBOOT
diff --git a/src/mainboard/google/brox/Kconfig.name b/src/mainboard/google/brox/Kconfig.name
index 37fc310..ae8f5ea 100644
--- a/src/mainboard/google/brox/Kconfig.name
+++ b/src/mainboard/google/brox/Kconfig.name
@@ -8,5 +8,8 @@
config BOARD_GOOGLE_BROX_EC_ISH
bool "-> Brox EC ISH"

+config BOARD_GOOGLE_LOTSO
+ bool "-> Lotso"
+
config BOARD_GOOGLE_GREENBAYUPOC
bool "-> Greenbayupoc"
diff --git a/src/mainboard/google/brox/variants/lotso/include/variant/ec.h b/src/mainboard/google/brox/variants/lotso/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h b/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
new file mode 100644
index 0000000..c4fe342
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/include/variant/gpio.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif
diff --git a/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk b/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
new file mode 100644
index 0000000..eace2e4
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/Makefile.mk
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = placeholder
diff --git a/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt b/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name ID to assign
diff --git a/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt b/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
new file mode 100644
index 0000000..2499005
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/memory/mem_parts_used.txt
@@ -0,0 +1,11 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Generated IDs are dependent on the order of parts in this file,
+# so new parts must always be added at the end of the file!
+#
+# Generate an updated Makefile.mk and dram_id.generated.txt by running the
+# part_id_gen tool from util/spd_tools.
+# See util/spd_tools/README.md for more details and instructions.
+
+# Part Name
diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb
new file mode 100644
index 0000000..4f2c04a
--- /dev/null
+++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/alderlake
+
+ device domain 0 on
+ end
+
+end

To view, visit change 81817. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Gerrit-Change-Number: 81817
Gerrit-PatchSet: 7
Gerrit-Owner: Kun Liu <liukun11@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jian Tong <tongjian@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged