Felix Held submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved
soc/intel/alderlake: Add Twinlake graphics device IDs

Add the graphics device IDs for Twinlake platform based on
Platform External Design Specification.

Document ID: 645548

BUG=b:326901448
TEST=Build tivviks and verify the IGD IDs.

Change-Id: Ide008d5c5302bd589784bc917a2610c42a0fdee4
Signed-off-by: Sowmya V <v.sowmya@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82038
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
---
M src/include/device/pci_ids.h
M src/soc/intel/alderlake/bootblock/report_platform.c
M src/soc/intel/common/block/graphics/graphics.c
3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 7831d5b..d3ba149 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -4147,6 +4147,8 @@
#define PCI_DID_INTEL_RPL_U_GT4 0xa7ac
#define PCI_DID_INTEL_RPL_U_GT5 0xa7ad
#define PCI_DID_INTEL_LNL_M_GT2 0x64a0
+#define PCI_DID_INTEL_TWL_GT1_1 0x46D3
+#define PCI_DID_INTEL_TWL_GT1_2 0x46D4

/* Intel Northbridge Ids */
#define PCI_DID_INTEL_APL_NB 0x5af0
diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c
index bd4960d..cd4ac00 100644
--- a/src/soc/intel/alderlake/bootblock/report_platform.c
+++ b/src/soc/intel/alderlake/bootblock/report_platform.c
@@ -236,7 +236,9 @@
{ PCI_DID_INTEL_RPL_S_GT0, "Raptorlake S GT0" },
{ PCI_DID_INTEL_RPL_S_GT1_1, "Raptorlake S GT1" },
{ PCI_DID_INTEL_RPL_S_GT1_2, "Raptorlake S GT1" },
- { PCI_DID_INTEL_RPL_S_GT1_3, "Raptorlake S GT1" }
+ { PCI_DID_INTEL_RPL_S_GT1_3, "Raptorlake S GT1" },
+ { PCI_DID_INTEL_TWL_GT1_1, "Twinlake GT1" },
+ { PCI_DID_INTEL_TWL_GT1_2, "Twinlake GT1" },
};

static inline uint8_t get_dev_revision(pci_devfn_t dev)
diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c
index ef4b269..eabcb9a 100644
--- a/src/soc/intel/common/block/graphics/graphics.c
+++ b/src/soc/intel/common/block/graphics/graphics.c
@@ -456,6 +456,8 @@
PCI_DID_INTEL_RPL_HX_GT2,
PCI_DID_INTEL_RPL_HX_GT3,
PCI_DID_INTEL_RPL_HX_GT4,
+ PCI_DID_INTEL_TWL_GT1_1,
+ PCI_DID_INTEL_TWL_GT1_2,
0,
};


To view, visit change 82038. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide008d5c5302bd589784bc917a2610c42a0fdee4
Gerrit-Change-Number: 82038
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged