Attention is currently required from: Tim Wawrzynczak, Brandon Breitenstein. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/5fac38e6_9960a1cb PS2, Line 286: system_requires_early_display
Oops I added this to the next patch instead of this one I'll move it to this one if that matters
Yes, let's please move it to this CL. There is no use adding a function in this CL and immediately dropping it in the next. Adds to confusion later on when someone is reading these changes.
https://review.coreboot.org/c/coreboot/+/47684/comment/cc9ced03_8e5e83d2 PS2, Line 296: __weak
wouldn't the build fail if EARLY_TCSS_DISPLAY is not selected but EARLY_TCSS is without weak functio […]
If the call to the function is properly guarded with if (CONFIG(EARLY_TCSS_DISPLAY)) then there should not be a build failure.