Attention is currently required from: Alexander Couzens, Angel Pons, David Hendricks, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Martin L Roth, Matt DeVillier, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford.
View Change
1 comment:
Patchset:
Patch Set #2:
Yeah. […]
@foss@mniewoehner.de - you can extend a choice from another Kconfig if the choice is named, like `choice MAINBOARD_MODEL_<vendor>` (mentioned this in another comment too - https://review.coreboot.org/c/coreboot/+/83119/comments/52813f26_fffaa591). Still requires modifying the in-tree Kconfigs though since they don't have names right now.
To view, visit change 83119. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727
Gerrit-Change-Number: 83119
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich@gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Varshit Pandya <pandyavarshit@gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Philipp Hug <philipp@hug.cx>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Jeremy Soller <jeremy@system76.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Attention: Tim Crawford <tcrawford@system76.com>
Gerrit-Attention: Sean Rhodes <sean@starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Attention: Ron Minnich <rminnich@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Mon, 01 Jul 2024 13:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>