Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: intel/skylake: Implement PCIe RP devicetree update based on DID ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35985/11/src/soc/intel/skylake/chip... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35985/11/src/soc/intel/skylake/chip... PS11, Line 51: case PCI_DEVICE_ID_INTEL_SPT_LP_PCIE_RP1: /* Fall through. */
Oh... was nearly through implementing the array idea, then realized that […]
This feels like artificially blowing up the code... OTOH the new approach is less error-prone and more generic
https://review.coreboot.org/c/coreboot/+/35985/11/src/soc/intel/skylake/chip... PS11, Line 77: mapper
mapping? or map?
Done