Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41026 )
Change subject: soc/intel/tigerlake: update elog to include CSME reset causes
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41026/1/src/soc/intel/tigerlake/elo...
File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/41026/1/src/soc/intel/tigerlake/elo...
PS1, Line 66: ps->hpr_cause0
is there a reason not to log the entire cause register?
The others are far less interesting... they include SMBUS or eSPI slaves causing a reset, SYS_RESET# 0xCF9 writes, and the TCO watchdog expiring the 2nd time. I imagine it will be useful for helping to debug CB:35403 and friends once we've gotten further along with that functionality.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32ffb55ff2ad26ec4e7609c41fc65e021a327a14
Gerrit-Change-Number: 41026
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 May 2020 21:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Levin
levinale@google.com
Gerrit-MessageType: comment