Attention is currently required from: Justin Frodsham, Raul Rangel, Subrata Banik, Andrey Petrov, Patrick Rudolph, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50090 )
Change subject: drivers/intel/fsp2_0: factor out and improve UPD signature check
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/50090/comment/d35b35fc_40cd379a
PS2, Line 100: fsp_verify_upd_header_signature
nit: Add a comment that the function dies if signatures don't match?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I469836e09db6024ecb448a5261439c66d8e65daf
Gerrit-Change-Number: 50090
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Jan 2021 15:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment