Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57815 )
Change subject: soc/intel/alderlake: Skip setting D0I3 bit for HECI devices
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57815/comment/b3660d29_86e7cc3f
PS4, Line 10: if coreboot decides to send EOP msg at post.
If possible, I'd like to know the reasoning for this change.
I would guess it's because HECI devices can't be used when the D0I3 bit is set? If so, why can't coreboot simply unset the D0I3 bit before sending EOP and set it again afterwards?
And if FSP no longer sets the D0I3 bit, doesn't coreboot need to set D0I3?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86d61c49b8f187611efd495712ad901184665f31
Gerrit-Change-Number: 57815
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 26 Sep 2021 10:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment