5 comments:
File src/arch/x86/assembly_entry.S:
Patch Set #6, Line 32: * executed code, are responsible for getting the processor into protected
Who exactly is responsible? Systems? (reset_vector.S in followup, it seems)
Patch Set #6, Line 36: _romstage_in_ram_continue:
It's because the preprocessor removes _start from this file.
Ah. I don't see why you need to define _start in CB:33759 at reset vector location. It used to be a symbol in protected mode, but is now located in realmode?
Patch Set #6, Line 43: call gdt_init
Wouldn't we want gdt init as well? Or a way to supply a different set of descriptors? I'd expect the […]
I see some GDT init in followup reset_vector.S already.
Patch Set #6, Line 55: rep stosl
Isn't this now redundant with wiping _car_region_start .. _end in reset_vector.S?
Patch Set #6, Line 72: call car_stage_entry
At the end of the day, does this entire file always reduce to the last call?
To view, visit change 32414. To unsubscribe, or for help writing mail filters, visit settings.