Attention is currently required from: Evan Green.

Evan Green uploaded patch set #3 to this change.

View Change

soc/intel: Return ACPI_S4 as previous sleep state

pmc_prev_sleep_state() isn't handling the case where acpi_sleep_from_pm1()
returns ACPI_S4. Pass that value along so it can get set as a
prev_sleep_state. Without this, consumers see prev_sleep_state as 0
and always treat resume as a cold boot. With this, consumers can
correctly do behavior specific to S4 resume, like skipping the
disconnect IPC command to the PMC on Alderlake systems.

BUG=b:230031158
TEST=Resume from S4 on Primus4es

Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689
---
M src/soc/intel/common/block/pmc/pmclib.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/64002/3

To view, visit change 64002. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689
Gerrit-Change-Number: 64002
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Green <evgreen@chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Evan Green <evgreen@chromium.org>
Gerrit-MessageType: newpatchset