Attention is currently required from: Shelley Chen, Furquan Shaikh, Tim Wawrzynczak, Michael Niewöhner, Aamir Bohra, Patrick Rudolph.

Michael Niewöhner uploaded patch set #2 to this change.

View Change

Revert "soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power idle"

This reverts commit 4d9d3f164de7002dd38f12dc40f9b260f63d2d9b.

Reason for revert:

The commit message does not make clear what the actual problem is or
was. The reference to a non-public bug tracker makes it quiet difficult
to make any sense of it.

According to the datasheets this means the Audio DSP oscillator is not
required to be powered off in order to enter SlpS0/S0ix. However, that
bit already defaults to zero and even FSP does not set it. Thus,
clearing that bit is not required.

Change-Id: Iff028364fb34f737c3a50809f2df623a0bba7218
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
---
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/finalize.c
M src/soc/intel/cannonlake/include/soc/pmc.h
3 files changed, 0 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57949/2

To view, visit change 57949. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff028364fb34f737c3a50809f2df623a0bba7218
Gerrit-Change-Number: 57949
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Grace Kao <grace.kao@intel.com>
Gerrit-CC: Kane Chen <kane.chen@intel.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Rajat Jain <rajatja@google.com>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: newpatchset