Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, approved Arthur Heymans: Looks good to me, approved
cpu/intel: Remove Core 2 Duo E8200 CPUID from model_6fx

With a CPUID of 10676, it is clearly model_1067x... Wait, it's already
there, but the comment is wrong. This ID isn't for Core Duo CPUs.

Change-Id: Ia4b73537805e2a8fa9e28bde76aa20a524f8f873
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44247
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/cpu/intel/model_1067x/model_1067x_init.c
M src/cpu/intel/model_6fx/model_6fx_init.c
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c
index cd774d3..6553f29 100644
--- a/src/cpu/intel/model_1067x/model_1067x_init.c
+++ b/src/cpu/intel/model_1067x/model_1067x_init.c
@@ -292,7 +292,7 @@
};

static const struct cpu_device_id cpu_table[] = {
- { X86_VENDOR_INTEL, 0x10676 }, /* Intel Core 2 Solo/Core Duo */
+ { X86_VENDOR_INTEL, 0x10676 },
{ X86_VENDOR_INTEL, 0x10677 },
{ X86_VENDOR_INTEL, 0x1067A },
{ 0, 0 },
diff --git a/src/cpu/intel/model_6fx/model_6fx_init.c b/src/cpu/intel/model_6fx/model_6fx_init.c
index e2755f8..d0987b4 100644
--- a/src/cpu/intel/model_6fx/model_6fx_init.c
+++ b/src/cpu/intel/model_6fx/model_6fx_init.c
@@ -146,7 +146,6 @@
{ X86_VENDOR_INTEL, 0x06fb }, /* Intel Core 2 Solo/Core Duo */
{ X86_VENDOR_INTEL, 0x06fd }, /* Intel Core 2 Solo/Core Duo */
{ X86_VENDOR_INTEL, 0x10661 }, /* Intel Core 2 Celeron Conroe-L */
- { X86_VENDOR_INTEL, 0x10676 }, /* Core2 Duo E8200 */
{ 0, 0 },
};


To view, visit change 44247. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4b73537805e2a8fa9e28bde76aa20a524f8f873
Gerrit-Change-Number: 44247
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-MessageType: merged