Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22810 )
Change subject: [draft] sb/intel/common: Automatically generate ACPI PIRQ ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
This is nice! a few small issues and nits though...
https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/d... File src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl:
https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/d... PS1, Line 7: * modify it under the terms of the GNU General Public License as just drop the file?
https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c@... PS1, Line 830: slot < 20 || slot > 31 || pci_pin < 1 || pci_pin > 4 slot 2 fn 0 also has a pin A that is always router to linkA.