Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Nick Vaccaro, Tarun.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 11:
indicating to the OS that S3
suspend is the preferred sleep method.
The description for the flag is:
A one informs OSPM that the platform is able to
achieve power savings in S0 similar to or better
than those typically achieved in S3. In effect,
when this bit is set it indicates that the system
will achieve no power benefit by making a sleep
transition to S3.
which I read as "tell the OS to prefer modern suspend over S3".
If you don't set it the OS cannot suspend that way.
Windows probably has no means to control which is used, but Linux can override which is used by `/sys/power/mem_sleep`. But Linux also seems to always claim s2idle support, even when `s0ix_enable` is not set, so I'm not sure how it's determining that.
To view, visit change 79631. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife98166338c5457fb2c7dad81a30e54f487495f6
Gerrit-Change-Number: 79631
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 15:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: comment