Jacob Garber has uploaded this change for review.

View Change

sb/amd/rs780: Use 32 bit variable to avoid truncation

The {read,write}_index functions expect a 32 bit value, as
do the bitwise operations.

Found-by: Coverity Scan #1229584
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: Idc2bc46c899d5a4e8b089644dca076a88d97dd7c
---
M src/southbridge/amd/rs780/ht.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32528/1

diff --git a/src/southbridge/amd/rs780/ht.c b/src/southbridge/amd/rs780/ht.c
index 94df233..a07839e 100644
--- a/src/southbridge/amd/rs780/ht.c
+++ b/src/southbridge/amd/rs780/ht.c
@@ -24,7 +24,7 @@
 void avoid_lpc_dma_deadlock(struct device *nb_dev, struct device *sb_dev)
 {
 	struct device *cpu_f0;
-	u8 reg;
+	u32 reg;
 
 	cpu_f0 = pcidev_on_root(0x18, 0);
 	set_nbcfg_enable_bits(cpu_f0, 0x68, 3 << 21, 1 << 21);

To view, visit change 32528. To unsubscribe, or for help writing mail filters, visit settings.