Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60268 )
Change subject: docker/Makefile: Use all instead of all_without_gdb ......................................................................
docker/Makefile: Use all instead of all_without_gdb
After removing GDB from crossgcc in commit f32eed16 (buildgcc: Remove GDB from crossgcc), there is no target named all_without_gdb anymore and we should always build crossgcc with target all.
But in util/docker/Makefile, we still try to build crossgcc with target all_without_gdb as default and will cause a build failure.
Set CROSSGCC_PARAM from all_without_gdb to all to fix this issue.
Signed-off-by: Hsuan Ting Chen roccochen@chromium.org Change-Id: I06c6d8e36dfd4e6a00ddec8b640b608ab1ba614c Reviewed-on: https://review.coreboot.org/c/coreboot/+/60268 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M util/docker/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve Felix Singer: Looks good to me, but someone else must approve
diff --git a/util/docker/Makefile b/util/docker/Makefile index 87e21be..cbe34f9 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -24,7 +24,7 @@ export DOCKER_CCACHE?=$(HOME)/.ccache
# SDK architecture -export COREBOOT_CROSSGCC_PARAM?=all_without_gdb +export COREBOOT_CROSSGCC_PARAM?=all
UID ?= $(shell id -u) GID ?= $(shell id -g)