3 comments:
File src/security/vboot/secdata_tpm.c:
Patch Set #3, Line 96: int attempts = 3;
We got rid of retries in depthcharge because we decided that our communication with Cr50 is reliable […]
Other upstream coreboot users are still using different TPMs. Those are probably reliable too, idk... but not really something I want to explore that much in this CL, I just wanted to remove this inconsistency (because everything else in this file uses this helper instead of safe_write() directly).
/*
* This seems the first time we've run. Initialize the TPM.
*/
Or perhaps also making this shorter than three lines?
Ack
Patch Set #3, Line 425: //RETURN_ON_FAILURE(factory_initialize_tpm(ctx));
If we're fixing any other random stuff in this CL, should we think about removing this line?
Sure.
To view, visit change 37471. To unsubscribe, or for help writing mail filters, visit settings.