Attention is currently required from: Felix Held.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 10: continued, since 32 is a valid value here.
And the case of limit > 32 should really be a BUG() or assert() since uint32t for the parameter 'value' is wrong then. I'll address this along the way.
It's a static function, with only constants passed for limit. Compiler probably drops the comparison completely.
To view, visit change 50243. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ca341841bad62abcb4ea26a350c539813a29de7
Gerrit-Change-Number: 50243
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Thu, 04 Feb 2021 09:35:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment