Patch Set 3:

Patch Set 3:

Any X86 platform that is not including this?

xeon_sp/cpx

It looks like this code only matters if !NO_SMM is selected. E.g. asus/p2b (SLOT_1 and therefore NO_SMM) remains the same with BUILD_TIMELESS. So maybe clean up that inclusion where it's not needed and have it depend on !NO_SMM?

View Change

To view, visit change 44231. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I478d3fd37d9f9c0daa4a704fdf5ba92b2028bf43
Gerrit-Change-Number: 44231
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 09 Aug 2020 11:59:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment