Felix Singer submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
mainboard: Drop invalid `VGA_BIOS_FILE` defaults

If the VGA BIOS file path for `VGA_BIOS_FILE` in a mainboard's Kconfig
does not exist in the coreboot tree (including submodules), drop it.
These files should be stored in the `site-local` subdirectory and the
paths specified for each board in `site-local/Kconfig`. For example:

config VGA_BIOS_FILE
default "site-local/x200_vbios.bin" if BOARD_LENOVO_X200

Note that this is just an example. There are better ways to structure
one's `site-local` subfolder. Using the `CONFIG_MAINBOARD_DIR` option
would be one of them, though variants may still need special handling.

Also, update autoport to not generate `VGA_BIOS_FILE` defaults.

Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51340
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M src/mainboard/amd/inagua/Kconfig
M src/mainboard/amd/persimmon/Kconfig
M src/mainboard/amd/south_station/Kconfig
M src/mainboard/amd/union_station/Kconfig
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asus/f2a85-m/Kconfig
M src/mainboard/getac/p470/Kconfig
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/folio_9480m/Kconfig
M src/mainboard/hp/snb_ivb_laptops/Kconfig
M src/mainboard/ibase/mb899/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/intel/emeraldlake2/Kconfig
M src/mainboard/intel/strago/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/jetway/nf81-t56n-lf/Kconfig
M src/mainboard/kontron/986lcd-m/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t440p/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/pcengines/apu1/Kconfig
M src/mainboard/protectli/vault_bsw/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/supermicro/x9scl/Kconfig
M src/mainboard/system76/lemp9/Kconfig
M util/autoport/main.go
44 files changed, 1 insertion(+), 190 deletions(-)

diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig
index 8346f52..3706b33 100644
--- a/src/mainboard/amd/inagua/Kconfig
+++ b/src/mainboard/amd/inagua/Kconfig
@@ -36,11 +36,6 @@
bool
default y

-#config VGA_BIOS_FILE
-# string "VGA BIOS path and filename"
-# depends on VGA_BIOS
-# default "rom/video/OntarioGenericVBios.bin"
-
config VGA_BIOS_ID
string "VGA device PCI IDs"
depends on VGA_BIOS
diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig
index b834570..66a05ee 100644
--- a/src/mainboard/amd/persimmon/Kconfig
+++ b/src/mainboard/amd/persimmon/Kconfig
@@ -37,11 +37,6 @@
bool
default y

-#config VGA_BIOS_FILE
-# string "VGA BIOS path and filename"
-# depends on VGA_BIOS
-# default "rom/video/OntarioGenericVbios.bin"
-
config VGA_BIOS_ID
string
default "1002,9802"
diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig
index 883be39..32eddb4 100644
--- a/src/mainboard/amd/south_station/Kconfig
+++ b/src/mainboard/amd/south_station/Kconfig
@@ -36,10 +36,6 @@
bool
default y

-config VGA_BIOS_FILE
- string
- default "site-local/vgabios.bin"
-
config VGA_BIOS_ID
string
default "1002,9806"
diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig
index ab92013..0c20e5f 100644
--- a/src/mainboard/amd/union_station/Kconfig
+++ b/src/mainboard/amd/union_station/Kconfig
@@ -35,10 +35,6 @@
bool
default y

-config VGA_BIOS_FILE
- string
- default "site-local/vgabios.bin"
-
config VGA_BIOS_ID
string
default "1002,9802"
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig
index 56194e0..5e8b1e0 100644
--- a/src/mainboard/apple/macbookair4_2/Kconfig
+++ b/src/mainboard/apple/macbookair4_2/Kconfig
@@ -22,10 +22,6 @@
config MAINBOARD_PART_NUMBER
default "MacBookAir4,2"

-config VGA_BIOS_FILE
- string
- default "pci8086,0116.rom"
-
config VGA_BIOS_ID
string
default "8086,0116"
diff --git a/src/mainboard/asus/f2a85-m/Kconfig b/src/mainboard/asus/f2a85-m/Kconfig
index 23c611d..a2e4f60 100644
--- a/src/mainboard/asus/f2a85-m/Kconfig
+++ b/src/mainboard/asus/f2a85-m/Kconfig
@@ -95,10 +95,6 @@
string
default "1002,9901"

-config VGA_BIOS_FILE
- string
- default "pci1002,9901.rom"
-
endif

config DEVICETREE
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig
index 4523a75..6af53d8 100644
--- a/src/mainboard/getac/p470/Kconfig
+++ b/src/mainboard/getac/p470/Kconfig
@@ -32,8 +32,4 @@
int
default 18

-config VGA_BIOS_FILE
- string
- default "getac-pci8086,27a2.rom"
-
endif # BOARD_GETAC_P470
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 0d37a10..61447fd 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -51,10 +51,6 @@
default "samus" if BOARD_GOOGLE_SAMUS
default ""

-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig
index 8ecba7a..00b33ad 100644
--- a/src/mainboard/google/beltino/Kconfig
+++ b/src/mainboard/google/beltino/Kconfig
@@ -40,10 +40,6 @@
string
default "Google_Beltino"

-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants except monroe
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig
index 55d731b..4eb151e 100644
--- a/src/mainboard/google/butterfly/Kconfig
+++ b/src/mainboard/google/butterfly/Kconfig
@@ -31,10 +31,6 @@
config MAINBOARD_PART_NUMBER
default "Butterfly"

-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
config MAINBOARD_VENDOR
string
default "Hewlett-Packard"
diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig
index 42be86a..2f54be9 100644
--- a/src/mainboard/google/jecht/Kconfig
+++ b/src/mainboard/google/jecht/Kconfig
@@ -33,10 +33,6 @@
default "Rikku" if BOARD_GOOGLE_RIKKU
default "Tidus" if BOARD_GOOGLE_TIDUS

-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants except tidus
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index 6926ca1..ee68e46 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -31,10 +31,6 @@
config MAINBOARD_PART_NUMBER
default "Link"

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index e596951..5fffcc1 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -32,10 +32,6 @@
config MAINBOARD_PART_NUMBER
default "Parrot"

-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index 7bb717b..e8963f7 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -48,10 +48,6 @@
config OVERRIDE_DEVICETREE
default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb"

-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants.
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig
index cdba84a..69cfdcc 100644
--- a/src/mainboard/google/stout/Kconfig
+++ b/src/mainboard/google/stout/Kconfig
@@ -30,10 +30,6 @@
config MAINBOARD_PART_NUMBER
default "Stout"

-config VGA_BIOS_FILE
- string
- default "pci8086,0156.rom"
-
config VGA_BIOS_ID
string
default "8086,0156"
diff --git a/src/mainboard/hp/folio_9480m/Kconfig b/src/mainboard/hp/folio_9480m/Kconfig
index 967743a..1e0f116 100644
--- a/src/mainboard/hp/folio_9480m/Kconfig
+++ b/src/mainboard/hp/folio_9480m/Kconfig
@@ -25,10 +25,6 @@
config MAINBOARD_PART_NUMBER
default "HP EliteBook Folio 9480m"

-config VGA_BIOS_FILE
- string
- default "pci8086,0a16.rom"
-
config VGA_BIOS_ID
string
default "8086,0a16"
diff --git a/src/mainboard/hp/snb_ivb_laptops/Kconfig b/src/mainboard/hp/snb_ivb_laptops/Kconfig
index 7a49bfd..d7e2a97 100644
--- a/src/mainboard/hp/snb_ivb_laptops/Kconfig
+++ b/src/mainboard/hp/snb_ivb_laptops/Kconfig
@@ -44,11 +44,6 @@
config OVERRIDE_DEVICETREE
default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb"

-config VGA_BIOS_FILE
- string
- default "pci8086,0116.rom" if SOUTHBRIDGE_INTEL_BD82X6X
- default "pci8086,0166.rom" if SOUTHBRIDGE_INTEL_C216
-
config VGA_BIOS_ID
string
default "8086,0116" if SOUTHBRIDGE_INTEL_BD82X6X
diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig
index d073f2b..05b0a09 100644
--- a/src/mainboard/ibase/mb899/Kconfig
+++ b/src/mainboard/ibase/mb899/Kconfig
@@ -26,8 +26,4 @@
int
default 18

-config VGA_BIOS_FILE
- string
- default "amipci_01.20"
-
endif # BOARD_IBASE_MB899
diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig
index 29f83f7..6d7bc8c 100644
--- a/src/mainboard/intel/baskingridge/Kconfig
+++ b/src/mainboard/intel/baskingridge/Kconfig
@@ -25,8 +25,4 @@
int
default 16

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
endif # BOARD_INTEL_BASKING_RIDGE
diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig
index 94d75d9..ebc172b 100644
--- a/src/mainboard/intel/dcp847ske/Kconfig
+++ b/src/mainboard/intel/dcp847ske/Kconfig
@@ -31,10 +31,6 @@
config MAINBOARD_PART_NUMBER
default "Intel NUC DCP847SKE"

-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
config VGA_BIOS_ID
string
default "8086,0106"
diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig
index f8a2e2e..86fe98a 100644
--- a/src/mainboard/intel/emeraldlake2/Kconfig
+++ b/src/mainboard/intel/emeraldlake2/Kconfig
@@ -27,8 +27,4 @@
int
default 16

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
endif # BOARD_INTEL_EMERALDLAKE2
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index c4a9842..64d5dfc 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -28,15 +28,6 @@
config MAINBOARD_PART_NUMBER
default "Strago"

-config VGA_BIOS_FILE
- string
- depends on VGA_BIOS
- default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin"
- help
- The C0 version of the video BIOS gets computed from this name
- so that they can both be added. Only the correct one for the
- system will be run.
-
config VGA_BIOS_ID
string
depends on VGA_BIOS
diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig
index 44a0cd4..cf16b8a 100644
--- a/src/mainboard/intel/wtm2/Kconfig
+++ b/src/mainboard/intel/wtm2/Kconfig
@@ -20,8 +20,4 @@
config MAINBOARD_PART_NUMBER
default "WHITETIP MOUNTAIN 2"

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
endif # BOARD_INTEL_WTM2
diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig
index 9b09700..e1eec04 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig
+++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig
@@ -37,11 +37,6 @@
bool
default y

-#config VGA_BIOS_FILE
-# string "VGA BIOS path and filename"
-# depends on VGA_BIOS
-# default "rom/video/OntarioGenericVbios.bin"
-
config VGA_BIOS_ID
string
default "1002,9806" # FUSION_G_T56N
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig
index 3235710..e8407de 100644
--- a/src/mainboard/kontron/986lcd-m/Kconfig
+++ b/src/mainboard/kontron/986lcd-m/Kconfig
@@ -28,8 +28,4 @@
int
default 18

-config VGA_BIOS_FILE
- string
- default "amipci_01.20"
-
endif # BOARD_KONTRON_986LCD_M
diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig
index 99b74fa..4745980 100644
--- a/src/mainboard/kontron/ktqm77/Kconfig
+++ b/src/mainboard/kontron/ktqm77/Kconfig
@@ -21,8 +21,4 @@
config MAINBOARD_PART_NUMBER
default "KTQM77/mITX"

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
endif # BOARD_KONTRON_KTQM77
diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig
index d212dad..971dd84 100644
--- a/src/mainboard/lenovo/l520/Kconfig
+++ b/src/mainboard/lenovo/l520/Kconfig
@@ -24,10 +24,6 @@
config MAINBOARD_PART_NUMBER
default "ThinkPad L520"

-config VGA_BIOS_FILE
- string
- default "pci8086,0126.rom"
-
config VGA_BIOS_ID
string
default "8086,0126"
diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig
index c779504..08f82aa 100644
--- a/src/mainboard/lenovo/s230u/Kconfig
+++ b/src/mainboard/lenovo/s230u/Kconfig
@@ -38,10 +38,6 @@
int
default 60

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config VGA_BIOS_ID
string
default "8086,0166"
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig
index d1cd0ec..6f4988c 100644
--- a/src/mainboard/lenovo/t420/Kconfig
+++ b/src/mainboard/lenovo/t420/Kconfig
@@ -60,10 +60,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0126.rom"
-
config VGA_BIOS_ID
string
default "8086,0126"
diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig
index db6e271..c46d4fc 100644
--- a/src/mainboard/lenovo/t420s/Kconfig
+++ b/src/mainboard/lenovo/t420s/Kconfig
@@ -59,10 +59,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0126.rom"
-
config VGA_BIOS_ID
string
default "8086,0126"
diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig
index 710dda2..dce078e 100644
--- a/src/mainboard/lenovo/t430s/Kconfig
+++ b/src/mainboard/lenovo/t430s/Kconfig
@@ -69,10 +69,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config ONBOARD_VGA_IS_PRIMARY
bool
default y
diff --git a/src/mainboard/lenovo/t440p/Kconfig b/src/mainboard/lenovo/t440p/Kconfig
index 991c1bd..a26b9b7 100644
--- a/src/mainboard/lenovo/t440p/Kconfig
+++ b/src/mainboard/lenovo/t440p/Kconfig
@@ -47,10 +47,6 @@
config MAINBOARD_PART_NUMBER
default "ThinkPad T440p"

-config VGA_BIOS_FILE
- string
- default "pci8086,0416.rom"
-
config VGA_BIOS_ID
string
default "8086,0416"
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig
index 5e12056..039baa6 100644
--- a/src/mainboard/lenovo/t520/Kconfig
+++ b/src/mainboard/lenovo/t520/Kconfig
@@ -71,10 +71,6 @@
string
default "8086,0126"

-config VGA_BIOS_FILE
- string
- default "pci8086,0126.rom"
-
config PS2K_EISAID
default "PNP0303"

diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index c2d649c..87be416 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -68,10 +68,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config VGA_BIOS_ID
string
default "8086,0166"
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
index d360c56..ec5092f 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
+++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
@@ -59,10 +59,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config VGA_BIOS_ID
string
default "8086,0166"
diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig
index 8530e49..61b3c14 100644
--- a/src/mainboard/lenovo/x220/Kconfig
+++ b/src/mainboard/lenovo/x220/Kconfig
@@ -67,15 +67,10 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0116.rom" if BOARD_LENOVO_X220I
- # FIXME: x1 with i3 cpu may also use "pci8086,0116.rom"
- default "pci8086,0126.rom"
-
config VGA_BIOS_ID
string
default "8086,0116" if BOARD_LENOVO_X220I
+ # FIXME: x1 with i3 cpu may also use "8086,0116"
default "8086,0126"

config PS2K_EISAID
diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index 61144b8..cafdead 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -70,10 +70,6 @@
int
default 10

-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config VGA_BIOS_ID
string
default "8086,0166"
diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig
index c617f98..d13c0ec 100644
--- a/src/mainboard/pcengines/apu1/Kconfig
+++ b/src/mainboard/pcengines/apu1/Kconfig
@@ -40,11 +40,6 @@
bool
default y

-#config VGA_BIOS_FILE
-# string "VGA BIOS path and filename"
-# depends on VGA_BIOS
-# default "rom/video/OntarioGenericVbios.bin"
-
config VGA_BIOS_ID
string
default "1002,9802"
diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig
index 1f9fa20..e169392 100644
--- a/src/mainboard/protectli/vault_bsw/Kconfig
+++ b/src/mainboard/protectli/vault_bsw/Kconfig
@@ -51,13 +51,6 @@
default "8086,157b" if BOARD_PROTECTLI_FW4B

if !RUN_FSP_GOP
-config VGA_BIOS_FILE
- string
- default "3rdparty/blobs/mainboard/protectli/vault_bsw/vgabios.bin"
- help
- The C0 version of the video bios gets computed from this name
- so that they can both be added. Only the correct one for the
- system will be run.

config VGA_BIOS_ID
string
diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig
index a2c08a0..d0574bb 100644
--- a/src/mainboard/samsung/lumpy/Kconfig
+++ b/src/mainboard/samsung/lumpy/Kconfig
@@ -35,10 +35,6 @@
config MAINBOARD_PART_NUMBER
default "Lumpy"

-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
if EARLY_PCI_BRIDGE

config EARLY_PCI_BRIDGE_DEVICE
diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig
index 58b5810..2a706b9 100644
--- a/src/mainboard/samsung/stumpy/Kconfig
+++ b/src/mainboard/samsung/stumpy/Kconfig
@@ -30,8 +30,4 @@
config MAINBOARD_PART_NUMBER
default "Stumpy"

-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
endif # BOARD_SAMSUNG_STUMPY
diff --git a/src/mainboard/supermicro/x9scl/Kconfig b/src/mainboard/supermicro/x9scl/Kconfig
index 4f46ca8..40b4213 100644
--- a/src/mainboard/supermicro/x9scl/Kconfig
+++ b/src/mainboard/supermicro/x9scl/Kconfig
@@ -25,10 +25,6 @@
int
default 1

-config VGA_BIOS_FILE
- string
- default "pci102b,0532.rom"
-
config VGA_BIOS_ID
string
depends on VGA_BIOS
diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig
index 81e9d3d..9b6cc76 100644
--- a/src/mainboard/system76/lemp9/Kconfig
+++ b/src/mainboard/system76/lemp9/Kconfig
@@ -55,10 +55,6 @@
config DIMM_MAX
default 2

-config VGA_BIOS_FILE
- string
- default "pci8086,9b41.rom"
-
config VGA_BIOS_ID
string
default "8086,9b41"
diff --git a/util/autoport/main.go b/util/autoport/main.go
index b889a95..9b0b436 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -510,9 +510,6 @@
KconfigString["VGA_BIOS_ID"] = fmt.Sprintf("%04x,%04x",
addr.PCIVenID,
addr.PCIDevID)
- KconfigString["VGA_BIOS_FILE"] = fmt.Sprintf("pci%04x,%04x.rom",
- addr.PCIVenID,
- addr.PCIDevID)
PutPCIDevParent(addr, g.Comment, g.MissingParent)
IGDEnabled = true
}

4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 51340. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2
Gerrit-Change-Number: 51340
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged