Paul Fagerburg submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
mb/google/dedede/var/cappy2: Add camera support

Add camera support in devicetree and associated GPIO configuration.

BUG=b:193397569
BRANCH=dedede
TEST=Camera function is OK

Signed-off-by: Sunwei Li <lisunwei@huaqin.corp-partner.google.com>
Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56647
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
---
A src/mainboard/google/dedede/variants/cappy2/Makefile.inc
A src/mainboard/google/dedede/variants/cappy2/gpio.c
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
3 files changed, 36 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/dedede/variants/cappy2/Makefile.inc b/src/mainboard/google/dedede/variants/cappy2/Makefile.inc
new file mode 100644
index 0000000..eb2c9bc
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/cappy2/Makefile.inc
@@ -0,0 +1,3 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+
+ramstage-y += gpio.c
diff --git a/src/mainboard/google/dedede/variants/cappy2/gpio.c b/src/mainboard/google/dedede/variants/cappy2/gpio.c
new file mode 100644
index 0000000..3ac420c
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/cappy2/gpio.c
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+
+/* Pad configuration in ramstage */
+static const struct pad_config gpio_table[] = {
+ /* D15 : EN_PP3300_CAMERA */
+ PAD_CFG_GPO(GPP_D15, 1, PLTRST),
+};
+
+const struct pad_config *variant_override_gpio_table(size_t *num)
+{
+ *num = ARRAY_SIZE(gpio_table);
+ return gpio_table;
+}
diff --git a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
index 88b27f9..41d1660 100644
--- a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb
@@ -30,7 +30,24 @@

register "disable_external_bypass_vr" = "1" # Does not support external vnn power rail

+ # USB Port Configuration
+ register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera
+
device domain 0 on
+ device pci 14.0 on
+ chip drivers/usb/acpi
+ device usb 0.0 on
+ chip drivers/usb/acpi
+ register "desc" = ""UFCamera""
+ register "type" = "UPC_TYPE_INTERNAL"
+ register "has_power_resource" = "1"
+ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D15)"
+ register "enable_delay_ms" = "20"
+ device usb 2.5 on end
+ end
+ end
+ end
+ end # USB xHCI
device pci 15.0 on
chip drivers/i2c/hid
register "generic.hid" = ""SYNA0A00""

To view, visit change 56647. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c
Gerrit-Change-Number: 56647
Gerrit-PatchSet: 8
Gerrit-Owner: Sunwei Li <lisunwei@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye@google.com>
Gerrit-Reviewer: Bob Moragues <moragues@google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Gerrit-MessageType: merged