Patch set 24:Code-Review +1
8 comments:
Patch Set #24, Line 10: - graphics
I would capitalize each element, as well as the acronyms:
- USB
- PCI root ports
- SD card
- eMMC
- Audio
- Basic UART configuration
nit: I would omit the "etc"
Patch Set #24, Line 24: jasper lake
nit: capitalized as `Jasper Lake` ?
File src/soc/intel/tigerlake/chip.h:
Patch Set #24, Line 208: enum {
Is this is a bitfield? If so, I would use shifts.
I mean, if the enum values are used like this:
u8 some_variable = DEBUG_INTERFACE_UART | DEBUG_INTERFACE_TRACEHUB;
Then I would change the hex constants to be like this:
enum {
DEBUG_INTERFACE_RAM = (1 << 0),
DEBUG_INTERFACE_UART = (1 << 1),
DEBUG_INTERFACE_USB3 = (1 << 3),
DEBUG_INTERFACE_SERIAL_IO = (1 << 4),
DEBUG_INTERFACE_TRACEHUB = (1 << 5),
} debug_interface_flag;
This is functionally equivalent, but it is more self-explanatory :)
File src/soc/intel/tigerlake/fsp_params_jsl.c:
Shouldn't this mirror the value above?
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
Patch Set #24, Line 32: disable
disable*d*
PCI
VT-d
To view, visit change 38461. To unsubscribe, or for help writing mail filters, visit settings.