[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 17:

(4 comments)

https://review.coreboot.org/#/c/31284/17/src/soc/intel/cannonlake/fsp_params... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31284/17/src/soc/intel/cannonlake/fsp_params... 
PS17, Line 43: static uint8_t get_param_value (const config_t *config, uint32_t dev_offset)
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/31284/17/src/soc/intel/cannonlake/fsp_params... 
PS17, Line 48: 	if (!dev || !dev->enabled) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/31284/17/src/soc/intel/cannonlake/fsp_params... 
PS17, Line 53: 	    (config->SerialIoDevMode[dev_offset] == PchSerialIoNotInitialized)){
space required before the open brace '{'

https://review.coreboot.org/#/c/31284/17/src/soc/intel/cannonlake/fsp_params... 
PS17, Line 88: 	for (int i = 0; i < ARRAY_SIZE(serial_io_dev); i++) {
braces {} are not necessary for single statement blocks