Attention is currently required from: Jason Glenesk, Marshall Dawson, Jason Nein, Matt Papageorge, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58803 )
Change subject: vc/amd/agesa: fix out-of-bounds read
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58803/comment/0ae09f7b_0c7062e6
PS3, Line 10:
Should add a pointer to issue tracker which can get event in coreboot gerrit.
BUG=b:147411796
File src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15MmioMap.c:
https://review.coreboot.org/c/coreboot/+/58803/comment/1eecc2aa_8bcbd486
PS3, Line 232: (MmioPair + i) < MMIO_REG_PAIR_NUM
Should the check be done before accessing the table (before &&)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01e134cb6b025bf7cb5030cd9378297d7f6df509
Gerrit-Change-Number: 58803
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Nein
finaljason@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Nein
finaljason@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Nov 2021 01:48:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment