Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39940 )
Change subject: mb/google/auron: Convert variants to use override devicetree ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 3: # Enable eDP Hotplug with 6ms pulse : register "gpu_dp_d_hotplug" = "0x06" : : # Disable DisplayPort C Hotplug : register "gpu_dp_c_hotplug" = "0x00" : : # Enable HDMI Hotplug with 6ms pulse : register "gpu_dp_b_hotplug" = "0x06" These seem to be overriden later, is it intentional?
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39940/6/src/mainboard/google/auron/... PS6, Line 4: register "gpu_dp_b_hotplug" = "0x06" This rewrites the same value, is it intentional?