3 comments:
File src/soc/intel/common/block/cse/cse.c:
remove extra line.
you mean error returns 0 and success returns -1? that strange should that be opposite ?
see what you have mentioned here https://review.coreboot.org/c/coreboot/+/35225/15/src/soc/intel/common/block/include/intelblocks/cse.h#57
File src/soc/intel/common/block/include/intelblocks/cse.h:
Patch Set #15, Line 57: * Returns 0 on failure 1 on success.
you are doing something else in the function
File src/soc/intel/skylake/me.c:
Patch Set #15, Line 282: intel_me_status
are you also plan to move this into common code ? if yes then why don't you do it here in this CL so, it looks very nit.
To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.