Attention is currently required from: Matt DeVillier.
View Change
1 comment:
Patchset:
Patch Set #6:
works as expected / documented on google/fizz, though not sure that specifying the screen rotation a […]
I have to admit I'm biased by the OEM perspective. If we build a panel into
a machine rotated to the left, I want to set 90°. But that's generally what
we do, isn't it? describe the hardware, not the software mechanism that
adapts to it.
Of course, if the integrator failed to configure the correct setting, the
user will want to rotate the framebuffer and that's just the opposite
direction... not sure how to make both happy :-/
To view, visit change 38922. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac75cefbd34f28c55ec20ee152fe67351cc48653
Gerrit-Change-Number: 38922
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Comment-Date: Sun, 11 Apr 2021 12:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-MessageType: comment