Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: soc/intel: Implement PCIe RP devicetree update based on LCAP
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/common/block...
File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/35985/19/src/soc/intel/common/block...
PS19, Line 158: link
maybe prev is a better name (like in device/pci_device. […]
Hmmm, I'm not a fan of `prev`/`next` names if there is no associated
`current`. If `prev` alone makes sense depends on the line that one
reads. e.g. `prev = &dev->sibling`: at the time that will be executed,
it's not the previous, it's the next...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib17d2b6fd34608603db3936d638bdf5acb46d717
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 19
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 Nov 2019 14:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment