Patch Set 1:

Patch Set 1:

(1 comment)

If you rebase on the latest code, I think this commit should go away.

Yes, I get the comment and code from that commit... Should I redo the comment or leave it because is already in the latest code?

What I'm saying is that it looked like your starting point is out of date, and this particular change has already gone in. If you run "git fetch && git rebase origin/master", then you'll no longer need this commit at all. OTOH if I'm misreading it, then you should change the commit message to match what this commit actually does.

View Change

To view, visit change 37532. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48fb3e9e48893336416eb90f80957e5bd21d1711
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 2
Gerrit-Owner: Jorge Fernandez
Gerrit-Reviewer: Jorge Fernandez
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Frans Hendriks <fhendriks@eltan.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 09 Dec 2019 21:07:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment