Patch Set 20:

Patch Set 20:

Hi Philipp/Patrick R.,

I believe I encountered a bug or a setup issue with Gerrit. Following is the sequence:
a. I submitted a new version of patch set.
b. I edited the commit message in Gerrit.
c. I noticed that the build failed: https://qa.coreboot.org/job/coreboot-gerrit/102331/ .
d. I do not know how to trigger a new build, I tried different ways. In the end, I had to introduce a dummy change.

Thanks for looking into this.

What happened is that you updated the patch set (from PS16 to PS17) while PS16 was still being built. The system then killed the build (the log says "Aborted by new patch set.").

That repeated for patch sets 17-19, only patch set 20 got the time to complete the build.

Thanks Patric for looking at this.
I will remember not to update commit message while a system validation is in progress.

Cheers,
Jonathan

View Change

1 comment:

• File src/drivers/vpd/vpd_premem.c:

  • Patch Set #20, Line 26: struct vpd_blob

    I'd prefer to use '*b' instead.

    Thanks! This makes sense.

To view, visit change 34634. To unsubscribe, or for help writing mail filters, visit settings.