[coreboot-gerrit] Change in ...coreboot[master]: soc/sifive/fu540: add code to initialize flash

[Xiang Wang (Code Review)]

Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30466 )

Change subject: soc/sifive/fu540: add code to initialize flash
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
File src/mainboard/sifive/hifive-unleashed/flash.c:

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
PS10, Line 30: 	.command_code = 0x6c
> please use a constant for 0x6c. […]

Done

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
PS10, Line 40: 			0x66,
> same here. please use a constant or add a comment.

Done