Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
View Change
2 comments:
Patchset:
Patch Set #172:
Very nice. It’d be great if you wrapped the comments as the linter scripts commented, but the rest looks nice.
I will address this in the next patchset.
Out of curiosity, how did you create the ASL files?
I started with the tables decoded by iASL, then modified and improved them (in some instances) based on comments here. For instance, while the EC (ACPI; over I/O) memory map is being used, a certain register has to be written to obtain different pieces of information about the battery state. In an MMIO-based memory map (LPC device has a "generic memory register" - LGMR), the data does not overlap and this isn't needed.
Patch Set #172:
Build failure for patch set 171: […]
The vendor firmware used some I/O port writes to seemingly 'trigger' the EC to handle commands. However, a different firmware phase (DXE) uses `Stall(15)` equivalently - in coreboot, this would be `mdelay` - and reads from the port always return 0xFF.
Therefore, I will remove this.
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 172
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 23:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment